Remove un-necessary INGRESSGATEWAY variables. #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a variable makes the commands longer and doesn't provide any benefit since: 1. the variable name is almost as long as the value. 2. it's only used a single time
kameshsampath
added
the
priority/low
Contributor
|
until v0.4 there was both ingress-gateway and knative-ingress-gateway so we need to decide which to use. Also there are chances we can use other gateways in future. So its better to have like that now. will come back to it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a variable makes the commands longer and doesn't provide any benefit since: