Skip to content

Add Miscellaneous components card on Final Page#1374

Merged
dgolovin merged 4 commits intoredhat-developer-tooling:masterfrom
mohitsuman:gh-1340
Apr 10, 2018
Merged

Add Miscellaneous components card on Final Page#1374
dgolovin merged 4 commits intoredhat-developer-tooling:masterfrom
mohitsuman:gh-1340

Conversation

@mohitsuman
Copy link
Copy Markdown
Collaborator

@mohitsuman mohitsuman commented Apr 10, 2018

This will add third card component apart from DevStudio and CDK. It will be without Get Started/Docs/Learn links as of now.

Fix #1340

screen shot 2018-04-10 at 7 30 17 am

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 10, 2018

Codecov Report

Merging #1374 into master will decrease coverage by 1.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   93.25%   92.23%   -1.03%     
==========================================
  Files          47       47              
  Lines        4847     4968     +121     
  Branches      543      864     +321     
==========================================
+ Hits         4520     4582      +62     
- Misses        327      357      +30     
- Partials        0       29      +29
Impacted Files Coverage Δ
browser/pages/start/controller.js 81.2% <81.25%> (-18.8%) ⬇️
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) ⬇️
browser/pages/install/controller.js 91.86% <0%> (-1.75%) ⬇️
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) ⬇️
browser/model/che.js 95% <0%> (-1.62%) ⬇️
browser/services/platform.js 98.14% <0%> (-1.48%) ⬇️
browser/pages/account/controller.js 98.61% <0%> (-1.39%) ⬇️
browser/model/cdk.js 97.6% <0%> (-1.16%) ⬇️
browser/model/devstudio-p2-zip.js 64.4% <0%> (-1.12%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ab0ad...6526da0. Read the comment docs.

@mohitsuman mohitsuman requested a review from dgolovin April 10, 2018 02:05
@mohitsuman
Copy link
Copy Markdown
Collaborator Author

test this

@dgolovin dgolovin merged commit 241bdde into redhat-developer-tooling:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants