JBDS-3878 pull installer version from... #165
Conversation
|
This PR is not quite perfect.... ran fine, built fine, even the tests ran OK. But on launch of the 1.6G installer, I get: So either need a different way to depend on package.json, or need to copy that file over into the .asar file somehow. @dgolovin @joshuawilson @jrichter1 @ppitonak any suggestion how to do that? |
|
|
||
| generate(jbdsInstallDir, jdkInstallDir) { | ||
| let jbdsVersion = "9.1"; | ||
| let pjson = require('../../package.json'); |
There was a problem hiding this comment.
DevStudio version should be loaded from requirements.json, not from package.json. It also wont work for tests and install time the same way, because root folder is different.
There was a problem hiding this comment.
OK, so I can switch to the other file and parse it out of the jbds.jar URL ... but that doesn't help with the other problem re: "no such file or directory" ... does it?
There was a problem hiding this comment.
Could DevStudio product build just generate contents.json (similar to eclipse p2 repo) with some additional info
{
"name": "Red Hat Developer Studio Nightly Build",
"version": "10.0.0.Alpha2",
"timestamp": "<buildQualifier>",
"installer": "filename"
}Installer could use base URL for contents.json and calculate url to download installer file and sha256 file for verification.
There was a problem hiding this comment.
You could also scrape the HTML page and get this information.
https://devstudio.jboss.com/10.0/snapshots/builds/devstudio.product_master/latest/all/ -> jboss-devstudio-10.0.0.Alpha1-v20160506-2012-B5309-installer-standalone.jar
2 participants
JBDS-3878 pull installer version from package.json