Build cleanup#25
Merged
Merged
Conversation
Collaborator
|
Can you comment on folder structure. I do not get what sdk folder does and why all source code is there. |
wtrocki
reviewed
Jun 16, 2021
Collaborator
|
I see that we have mustache file - is that gor dependency updates? |
Contributor
Author
|
@wtrocki it is the pom template that has 1) includes the information to publish packages and 2) fixes some dependencies rennovate was complaining about |
Contributor
Author
|
@wtrocki sdk folder? You mean what the SDK's in the packages directories are and are linked in the main readme? |
Collaborator
^^ |
Contributor
Author
|
It's the generated source code. That's my comment; what questions do you have? |
wtrocki
approved these changes
Jun 16, 2021
andreaTP
pushed a commit
to andreaTP/app-services-sdk-java
that referenced
this pull request
Jan 19, 2023
…_draft [WIP] Java draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes non maven build systems, adds sources to generated packages, and updates dependencies in the maven pom. Sources have been regenerated as well. The pom updates should keep the renovate away for a bit.