-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for custom repositories per offering #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ia3andy please add some coverage into this project please and share with us (on Slack) the link where these changes are deployed |
|
@rsvoboda to test this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for custom Maven repositories per offering (IBM, Red Hat, Red Hat Camel). The implementation allows each offering to inject its own Maven repository configuration into generated pom.xml files.
Key changes:
- Refactored constants into separate files per offering (
IBMConstants,RedHatConstants,RedHatCamelConstants,GlobalConstants) - Added
onNewProjectmethod to inject custom repositories into generated projects - Restructured Playwright tests with a common base class for different offering variations
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
OfferingPlatformOverride.java |
Implements repository injection logic via onNewProject method |
IBMConstants.java |
Contains IBM-specific presets and Maven repository configurations |
RedHatConstants.java |
Contains Red Hat Maven repository configurations |
RedHatCamelConstants.java |
Contains Red Hat Camel-specific presets |
GlobalConstants.java |
Contains shared constants (icons URL and tags) |
PlaywrightTestBase.java |
Refactored into abstract base class for offering-specific tests |
RedHatOfferingTest.java |
Test implementation for Red Hat offering |
RedHatCamelOfferingTest.java |
Test implementation for Red Hat Camel offering |
IBMOfferingTest.java |
Test implementation for IBM offering |
application.properties |
Updated bundle keys and UI IDs for offerings |
theme.scss (both files) |
Fixed SCSS import syntax to use @use with namespace |
justfile |
Updated environment variables for different offerings |
deploy/build_deploy.sh |
Added stage detection logic based on commit message |
pom.xml |
Version bump from 59 to 61 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aloubyansky @tqvarnst @rsvoboda @fmongiar
this needs to be carefully tested