Skip to content

Conversation

@ia3andy
Copy link
Collaborator

@ia3andy ia3andy commented Nov 26, 2025

@aloubyansky @tqvarnst @rsvoboda @fmongiar
this needs to be carefully tested

@ia3andy ia3andy changed the title Add support for custom repositories Add support for custom repositories per offering Nov 26, 2025
@rsvoboda
Copy link

this needs to be carefully tested

@ia3andy please add some coverage into this project please and share with us (on Slack) the link where these changes are deployed

@ia3andy
Copy link
Collaborator Author

ia3andy commented Nov 27, 2025

@rsvoboda to test this:

  • Clone this PR locally
  • Install just
  • Build just build
  • Run just start-rh, just start-camel, just start-ibm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for custom Maven repositories per offering (IBM, Red Hat, Red Hat Camel). The implementation allows each offering to inject its own Maven repository configuration into generated pom.xml files.

Key changes:

  • Refactored constants into separate files per offering (IBMConstants, RedHatConstants, RedHatCamelConstants, GlobalConstants)
  • Added onNewProject method to inject custom repositories into generated projects
  • Restructured Playwright tests with a common base class for different offering variations

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
OfferingPlatformOverride.java Implements repository injection logic via onNewProject method
IBMConstants.java Contains IBM-specific presets and Maven repository configurations
RedHatConstants.java Contains Red Hat Maven repository configurations
RedHatCamelConstants.java Contains Red Hat Camel-specific presets
GlobalConstants.java Contains shared constants (icons URL and tags)
PlaywrightTestBase.java Refactored into abstract base class for offering-specific tests
RedHatOfferingTest.java Test implementation for Red Hat offering
RedHatCamelOfferingTest.java Test implementation for Red Hat Camel offering
IBMOfferingTest.java Test implementation for IBM offering
application.properties Updated bundle keys and UI IDs for offerings
theme.scss (both files) Fixed SCSS import syntax to use @use with namespace
justfile Updated environment variables for different offerings
deploy/build_deploy.sh Added stage detection logic based on commit message
pom.xml Version bump from 59 to 61

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ia3andy and others added 4 commits November 27, 2025 18:45
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ia3andy ia3andy merged commit fddd7aa into redhat-developer:main Nov 27, 2025
1 check passed
@ia3andy
Copy link
Collaborator Author

ia3andy commented Nov 28, 2025

@tqvarnst @rsvoboda i added a lot of new tests and the option to deploy to staging only. This PR is on all staging. Also I just kept the IBM repositories. Is there a reason not to add it to the others? I might be missing something

@ia3andy ia3andy deleted the custom-repo branch December 1, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants