Skip to content
This repository was archived by the owner on Oct 3, 2019. It is now read-only.

Conversation

@baijum
Copy link
Collaborator

@baijum baijum commented May 2, 2019

This confuration should work with any operator registry location.
The location is provided as an arument with default value pointing to
OpenShift CI.

This confuration should work with any operator registry location.
The location is provided as an arument with default value pointing to
OpenShift CI.
@baijum baijum changed the title Use the base available in the OpenShift CI Use the base image available in the OpenShift CI May 2, 2019
@@ -1,24 +1,14 @@
FROM quay.io/openshift/origin-operator-registry:latest

ARG image=registry.svc.ci.openshift.org/${OPENSHIFT_BUILD_NAMESPACE}/stable:devconsole-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, only the following are receptive towards environment variables.

ADD
COPY
ENV
EXPOSE
FROM
LABEL
STOPSIGNAL
USER
VOLUME
WORKDIR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


COPY manifests manifests
COPY deploy/crds/*.yaml manifests/devconsole/${version}/
RUN curl -L -s https://github.com/devconsole-operator-test-deps/operator-registry-binaries/releases/download/v0.1.0/appregistry-server -o /bin/appregistry-server \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep only these changes and have this PR merged?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 697d406

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Collaborator

@baijum: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 697d406 link /test images
ci/prow/lint 697d406 link /test lint
ci/prow/e2e 697d406 link /test e2e
ci/prow/e2e-ci 697d406 link /test e2e-ci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@baijum baijum changed the title Use the base image available in the OpenShift CI [DO NOT MERGE] Use the base image available in the OpenShift CI May 2, 2019
@baijum baijum changed the title [DO NOT MERGE] Use the base image available in the OpenShift CI Use the base image available in the OpenShift CI May 2, 2019
@baijum baijum merged commit 3ac6d36 into redhat-developer:master May 2, 2019
baijum added a commit to baijum/release that referenced this pull request May 2, 2019
- Ref: redhat-developer/devconsole-operator#175
- Enable verbose output for lint
- Increase memory limit
akashshinde added a commit to akashshinde/devopsconsole-operator that referenced this pull request May 3, 2019
* upstream/master:
  Set registry log (redhat-developer#176)
  Non-admin user viewing the console with developer console perspective (redhat-developer#136)
  Use the base image available in the OpenShift CI (redhat-developer#175)
@baijum baijum deleted the ci-operator-registry branch May 4, 2019 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants