Skip to content
This repository was archived by the owner on Oct 3, 2019. It is now read-only.

Conversation

@pmacik
Copy link
Contributor

@pmacik pmacik commented May 16, 2019

This PR installs chromium-headless and chromedriver packages from epel-release to the root image.
These are the dependencies needed to run the UI tests (#206) on CI.

@openshift-ci-robot
Copy link
Collaborator

Hi @pmacik. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@baijum
Copy link
Collaborator

baijum commented May 16, 2019

/ok-to-test

Copy link
Collaborator

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik pmacik changed the title test-ui-devperspective: Add chromedriver to the tools images Add chromedriver to the tools images May 16, 2019
@baijum baijum merged commit 856836e into redhat-developer:master May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants