fix: Gateway plugin should list the workspaces created from a custom editor definition#189
Merged
adietish merged 1 commit intoredhat-developer:mainfrom Oct 16, 2025
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 4 32 +28
Lines 26 1151 +1125
Branches 0 199 +199
=======================================
- Misses 26 1151 +1125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
Any chance to see the stacktrace? |
vrubezhny
force-pushed
the
fix-custom-workspaces-not-listed
branch
2 times, most recently
from
65eea6e to
bef35e3
Compare
adietish
approved these changes
Oct 15, 2025
Collaborator
adietish
left a comment
adietish
left a comment
There was a problem hiding this comment.
LGTM.
Tested it with the custom editor definition that was causing an error for @azatsarynnyy. Worked well for me.
src/main/kotlin/com/redhat/devtools/gateway/openshift/DevWorkspace.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/redhat/devtools/gateway/openshift/DevWorkspace.kt
Outdated
Show resolved
Hide resolved
vrubezhny
force-pushed
the
fix-custom-workspaces-not-listed
branch
from
bef35e3 to
ac85fa5
Compare
vrubezhny
force-pushed
the
fix-custom-workspaces-not-listed
branch
from
ac85fa5 to
a759101
Compare
vrubezhny
force-pushed
the
fix-custom-workspaces-not-listed
branch
from
a759101 to
f005d7c
Compare
…editor definition The DevWorkspaceTemplate object is used to detect if the JetBrains Idea based editor was used to create a WS Fixes: eclipse-che/che#23610 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fix-custom-workspaces-not-listed
branch
from
f005d7c to
8b017dc
Compare
adietish
approved these changes
Oct 16, 2025
Collaborator
adietish
left a comment
adietish
left a comment
There was a problem hiding this comment.
works great for me. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DevWorkspaceTemplate object is used to detect if the JetBrains Idea based editor was used to create a WS
Fixes: eclipse-che/che#23610