Skip to content

fix: allow user to provide cluster url only (#23654)#218

Merged
adietish merged 1 commit intoredhat-developer:mainfrom
adietish:issue-23654
Nov 21, 2025
Merged

fix: allow user to provide cluster url only (#23654)#218
adietish merged 1 commit intoredhat-developer:mainfrom
adietish:issue-23654

Conversation

@adietish
Copy link
Collaborator

@adietish adietish self-assigned this Nov 18, 2025
@adietish adietish force-pushed the issue-23654 branch 3 times, most recently from a3a8ed6 to b11f560 Compare November 18, 2025 10:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 49.05660% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.60%. Comparing base (71098f6) to head (fc14aff).
⚠️ Report is 262 commits behind head on main.

Files with missing lines Patch % Lines
...ools/gateway/view/steps/DevSpacesServerStepView.kt 0.00% 11 Missing ⚠️
...dhat/devtools/gateway/view/ui/FilteringComboBox.kt 68.42% 2 Missing and 4 partials ⚠️
.../com/redhat/devtools/gateway/view/ui/SwingUtils.kt 0.00% 6 Missing ⚠️
...t/devtools/gateway/kubeconfig/KubeConfigMonitor.kt 0.00% 3 Missing ⚠️
...hat/devtools/gateway/kubeconfig/KubeConfigUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #218       +/-   ##
==========================================
+ Coverage   0.00%   18.60%   +18.60%     
==========================================
  Files          4       35       +31     
  Lines         26     1489     +1463     
  Branches       0      285      +285     
==========================================
+ Hits           0      277      +277     
- Misses        26     1184     +1158     
- Partials       0       28       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adietish adietish force-pushed the issue-23654 branch 5 times, most recently from 5d2fea1 to 25576c6 Compare November 18, 2025 19:20
@adietish adietish requested a review from vrubezhny November 18, 2025 21:38
@adietish adietish force-pushed the issue-23654 branch 4 times, most recently from 9c12323 to 795f780 Compare November 19, 2025 00:48
@adietish adietish marked this pull request as ready for review November 19, 2025 00:57
@adietish adietish force-pushed the issue-23654 branch 4 times, most recently from 61f61c0 to 06db728 Compare November 21, 2025 16:36
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Assisted by: gemini-cli
Assisted by: cursor
Assisted by: qwen-code
Copy link
Collaborator

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Thanks!

@adietish adietish merged commit 5c46dfa into redhat-developer:main Nov 21, 2025
5 checks passed
@adietish adietish deleted the issue-23654 branch November 21, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway: cannot connect when providing url + token (only works when selecting item in list)

3 participants