fix: dont throw if selected index is out of bound (#23678)#237
Merged
adietish merged 1 commit intoredhat-developer:mainfrom Dec 19, 2025
Merged
fix: dont throw if selected index is out of bound (#23678)#237adietish merged 1 commit intoredhat-developer:mainfrom
adietish merged 1 commit intoredhat-developer:mainfrom
Conversation
adietish
requested review from
azatsarynnyy,
tolusha and
vrubezhny
and removed request for
azatsarynnyy,
tolusha and
vrubezhny
adietish
force-pushed
the
issue-23678
branch
from
35fd525 to
7c9f6ac
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 0.00% 17.19% +17.19%
==========================================
Files 4 36 +32
Lines 26 1611 +1585
Branches 0 314 +314
==========================================
+ Hits 0 277 +277
- Misses 26 1306 +1280
- Partials 0 28 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adietish
force-pushed
the
issue-23678
branch
from
7c9f6ac to
f7347fc
Compare
Collaborator
Author
|
@vrubezhny, @azatsarynnyy: please review |
adietish
force-pushed
the
issue-23678
branch
from
f7347fc to
f6850e6
Compare
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
adietish
force-pushed
the
issue-23678
branch
from
f6850e6 to
fa05407
Compare
vrubezhny
approved these changes
Dec 19, 2025
Collaborator
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes eclipse-che/che#23678