added tests asserting results of RemoteIDEServer#waitServerReady/Terminated#241
Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom Jan 30, 2026
Conversation
…inated Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Collaborator
Author
|
@vrubezhny: this follows up on your PR #240. I added tests that assert the results when the server response has/doesnt have a joinLink or projects. Please review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 0.00% 25.57% +25.57%
==========================================
Files 4 40 +36
Lines 26 2088 +2062
Branches 0 428 +428
==========================================
+ Hits 0 534 +534
- Misses 26 1480 +1454
- Partials 0 74 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@vrubezhny please review |
vrubezhny
approved these changes
Jan 30, 2026
Collaborator
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follows up on #240
Added tests to assert the results of
RemoteIDEServer#waitServerReadyandRemoteIDEServer#waitServerTerminatedwhen the server response has/doesnt have a joinLink or projects