Skip to content

Use flat layout for zip published to the Marketplace#6

Merged
azatsarynnyy merged 1 commit into
mainfrom
packaging
May 21, 2026
Merged

Use flat layout for zip published to the Marketplace#6
azatsarynnyy merged 1 commit into
mainfrom
packaging

Conversation

@azatsarynnyy
Copy link
Copy Markdown
Member

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: e89ae1d0-3782-4769-a7b6-edf75e340c47

📥 Commits

Reviewing files that changed from the base of the PR and between 758fd55 and a2dc22f.

📒 Files selected for processing (1)
  • build-logic/src/main/kotlin/toolbox/buildlogic/PublishToolboxPlugin.kt

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated plugin distribution packaging to include all runtime dependencies alongside core plugin components.

Walkthrough

The packagePlugin Gradle task in the Toolbox build logic was updated to change how dependencies are packaged. The project jar is now included directly without a subdirectory path, and all runtime classpath artifacts are added to expand the plugin's packaged contents.

Changes

Plugin Package Configuration

Layer / File(s) Summary
JAR and dependency inclusion in plugin package
build-logic/src/main/kotlin/toolbox/buildlogic/PublishToolboxPlugin.kt
The packagePlugin ZIP task removes the destination directory (into("${target.group}/lib")) from jar inclusion and adds a step to include all artifacts from runtimeClasspath, expanding what is packaged into the plugin ZIP.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: modifying the ZIP layout for Marketplace publishing from nested to flat.
Description check ✅ Passed The description provides a reference to the related issue (CRW-10916), which is related to the changeset about ZIP packaging layout.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@azatsarynnyy azatsarynnyy merged commit e57fd76 into main May 21, 2026
2 of 3 checks passed
@azatsarynnyy azatsarynnyy deleted the packaging branch May 21, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant