fix: Apply Minor changes to AppProjects Details Page and Tabs#159
Merged
keithchong merged 2 commits intoredhat-developer:mainfrom Jan 26, 2026
Merged
Conversation
Signed-off-by: Atif Ali <atali@redhat.com>
keithchong
reviewed
Jan 19, 2026
| </div> | ||
| <div> | ||
| <strong>{t('Policy Effect')}:</strong>{' '} | ||
| {effect === 'allow' ? `✅ ${t('Allow')}` : `❌ ${t('Deny')}`} |
Collaborator
There was a problem hiding this comment.
Could we use fontawesome instead of embedding them into the source file?
eg. something like this:
<span className='fa fa-check-square' style={{ color: 'green' }}>
Collaborator
Author
There was a problem hiding this comment.
I also fixed this issue on Allow/Deny Lists cards, long group names in the "Group" column were being truncated.
Signed-off-by: Atif Ali <atali@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: GITOPS-8634
Help icon + ArgoCD Link on Allow/Deny, Roles and Sync Windows tabs
Tooltip under Roles tab with more description