Skip to content

Added smissing spec while creating NamespaceManagement CR from UI#1115

Merged
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:masterfrom
alkakumari016:GITOPS-7834
Apr 2, 2026
Merged

Added smissing spec while creating NamespaceManagement CR from UI#1115
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:masterfrom
alkakumari016:GITOPS-7834

Conversation

@alkakumari016
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Some values like name and default spec is missing in the UI while creating the NamespaceManagement CR. This PR fixes that and adds some default values like name and spec.managedBy fields.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?
GITOPS-7834

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Alka Kumari <alkumari@redhat.com>
@openshift-ci openshift-ci bot requested review from svghadi and wtam2018 April 2, 2026 04:40
Copy link
Copy Markdown
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@svghadi
Copy link
Copy Markdown
Member

svghadi commented Apr 2, 2026

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 2, 2026
@varshab1210
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

@alkakumari016: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 5d8a3f7 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alkakumari016
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit b4578e2 into redhat-developer:master Apr 2, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants