Skip to content

chore: fix accidental removal of sourceNamespaces from CRD#406

Merged
jaideepr97 merged 1 commit into
redhat-developer:v1.7from
jaideepr97:v1.7
Nov 23, 2022
Merged

chore: fix accidental removal of sourceNamespaces from CRD#406
jaideepr97 merged 1 commit into
redhat-developer:v1.7from
jaideepr97:v1.7

Conversation

@jaideepr97
Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci Bot requested review from jgwest and keithchong November 23, 2022 15:25
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jgwest for approval by writing /assign @jgwest in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
@jaideepr97 jaideepr97 merged commit d6a8842 into redhat-developer:v1.7 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant