Skip to content

Conversation

@iam-veeramalla
Copy link
Contributor

What type of PR is this?

/kind bug

What does this PR do / why we need it:
This PR will fix the issues w.r.t CI on release branch v1.8. Currently the build is completely broken.

Have you updated the necessary documentation?
NA

How to test changes / Special notes to the reviewer:

  1. Run the operator from this branch using make install
  2. Proceed with the regular workflow of creating ArgoCD CR
  3. Run e2e tests locally using make all

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
@openshift-ci openshift-ci bot requested review from jannfis and keithchong May 15, 2023 07:50
@varshab1210
Copy link
Member

Thanks Abhishek, works locally.

/lgtm

@iam-veeramalla
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2a90a1e into redhat-developer:v1.8 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants