fix: Add logging and visual feedback for rejected DAP breakpoints#1464
Merged
angelozerr merged 1 commit intoredhat-developer:mainfrom Apr 8, 2026
Merged
Conversation
Fixes redhat-developer#1433 When a breakpoint is registered during a debug session but rejected by supportsBreakpoint(), it was silently ignored with no feedback to the user or diagnostic information in logs. This could happen when: - sourcePosition is null (timing/race condition) - debugAdapterDescriptor.isDebuggableFile() returns false unexpectedly Changes: - Add detailed logging (enabled, sourcePosition, breakpoint type) when a breakpoint is rejected - Mark rejected breakpoints as invalid in the IDE with an explanatory message so users get immediate visual feedback - Improve separation of concerns in sendBreakpoints() for better clarity This helps diagnose the non-deterministic behavior reported in redhat-developer#1433 where breakpoints sometimes fail to register during active debug sessions. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1433
When a breakpoint is registered during a debug session but rejected by supportsBreakpoint(), it was silently ignored with no feedback to the user or diagnostic information in logs.
This could happen when:
Changes:
This helps diagnose the non-deterministic behavior reported in #1433 where breakpoints sometimes fail to register during active debug sessions.