Skip to content

change tkn image set in makefile#283

Merged
adrianriobo merged 1 commit intoredhat-developer:mainfrom
lilyLuLiu:main
Sep 16, 2024
Merged

change tkn image set in makefile#283
adrianriobo merged 1 commit intoredhat-developer:mainfrom
lilyLuLiu:main

Conversation

@lilyLuLiu
Copy link
Copy Markdown
Collaborator

@lilyLuLiu lilyLuLiu commented Sep 2, 2024

@anjannath
Copy link
Copy Markdown
Collaborator

LGTM

so when we want to now push a released 8.0.0 image we can use, e.g make VERSION=8.0.0 tkn-push

Comment thread tkn/infra-aws-mac.yaml Outdated
@adrianriobo
Copy link
Copy Markdown
Collaborator

Also I notice the tkn-bundle/tkn-check passed but that should not be the case, as the spec do not contain a valid image on it, it just contains the <IMAGE> field as the tkn-template is not being used there.

We have to issues there:

  • Ensure the template function is used somehow before they are deployed to the cluster on the check
  • Look for a way to dry/run or some type of test which may does not require credentials / or something we can pass empty to test the task will be able to run.

@lilyLuLiu lilyLuLiu force-pushed the main branch 2 times, most recently from 6d414d6 to f97921b Compare September 11, 2024 08:02
@lilyLuLiu
Copy link
Copy Markdown
Collaborator Author

@adrianriobo , I keep the orignal tkn yaml files and use another folder to store the templates. So tkn-bundle/tkn-check can check the validation of the tkn file. Also add make tkn-update in makefile for updating the version for tkn.

@adrianriobo adrianriobo merged commit 0de1c03 into redhat-developer:main Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants