feat(spot): more detailed debug logs#769
Merged
adrianriobo merged 1 commit intoredhat-developer:mainfrom Apr 9, 2026
Merged
Conversation
Collaborator
ppitonak
commented
Apr 8, 2026
- on demand: print which instance type was randomly chosen
- spot: print more details when no good choice was found
Collaborator
Author
|
Sample output |
adrianriobo
reviewed
Apr 9, 2026
pkg/provider/aws/data/spot.go
Outdated
| // Log diagnostic details to help understand why no choice was found | ||
| pricingRegions := utilMaps.Keys(args.spotPricing) | ||
| placementRegions := utilMaps.Keys(args.placementScores) | ||
| logging.Debugf("No spot choice found. Regions with pricing data: %v", pricingRegions) |
Collaborator
There was a problem hiding this comment.
Do we want this always or just if debug is enabled? I think this will print the trace as debug always as that do not check the ctx.Debug flag?
Collaborator
Author
There was a problem hiding this comment.
Oh, I didn't realize that it works this way. I pushed the fix
1. on demand: print which instance type was randomly chosen 2. spot: print more details when no good choice was found Signed-off-by: Pavol Pitonak <ppitonak@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.