fix(snc-profiles): Fix non reachable api while destroying SNC#810
Merged
Conversation
Previously we set the delete of any resource deployed on top of SNC as deleted with the underlaying infra, but even in that case during destroy pulumi was trying to reach the SNC api to check the state for resources, and when it is unrechable it was failing the whole destroy operation, we are now forcing the DeleteUnrechable to true, so it bypass it even if it can not reach the cluster to check the state. Fixes redhat-developer#809 Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change enables Pulumi's ChangesKubernetes Provider Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jangel97
approved these changes
May 20, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we set the delete of any resource deployed on top of SNC as deleted with the underlaying infra, but even in that case during destroy pulumi was trying to reach the SNC api to check the state for resources, and when it is unrechable it was failing the whole destroy operation, we are now forcing the DeleteUnrechable to true, so it bypass it even if it can not reach the cluster to check the state.
Fixes #809