Add support to perform build in "odo deploy" using S2I strategy

[Shraddhak22]

What type of PR is this?

/kind feature

What does does this PR do / why we need it:
This PR extends current "odo deploy" implementation by allowing build using S2I build strategy

• Adds support for performing S2I build in "odo deploy", and pushing images to either internal or external registry.

NOTE: This PR builds on top of work contained in #3478 and #3751, and must only be merged after #3478 and #3751 has been merged

Which issue(s) this PR fixes:

Fixes #3846

PR acceptance criteria:

• Unit test

How to test changes / Special notes to the reviewer:

• create a new directory, cd into it and run odo create nodejs --starter=nodejs-starter
• run odo url create
• replace created devfile with the following sample :

schemaVersion: 2.1.0
metadata:
  name: nodejs
  version: 1.0.0
  alpha.build-dockerfile: "https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/build/Dockerfile"
  alpha.deployment-manifest: "https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/deploy/deployment-manifest.yaml"
projects:
  - name: nodejs-starter
    git:
      location: "https://github.com/odo-devfiles/nodejs-ex.git"
buildGuidances:
  - s2i:
      name: s2i-build
      builderImageNamespace: "openshift"
      builderImageStreamTag: "nodejs:12"
      scriptLocation: "https://raw.githubusercontent.com/Shraddhak22/s2i-scripts/master/s2i/bin"
      incrementalBuild: true
components:
  - container:
      name: runtime
      image: registry.access.redhat.com/ubi8/nodejs-12:1-45
      memoryLimit: 1024Mi
      mountSources: true
      sourceMapping: /project
      endpoints:
        - name: http-3000
          targetPort: 3000
commands:
  - exec:
      id: install
      component: runtime
      commandLine: npm install
      workingDir: /project
      group:
        kind: build
        isDefault: true
  - exec:
      id: run
      component: runtime
      commandLine: npm start
      workingDir: /project
      group:
        kind: run
        isDefault: true
  - exec:
      id: debug
      component: runtime
      commandLine: npm run debug
      workingDir: /project
      group:
        kind: debug
        isDefault: true
  - exec:
      id: test
      component: runtime
      commandLine: npm test
      workingDir: /project
      group:
        kind: test
        isDefault: true

Note: scriptLocation and incrementalBuild are optional parameters for S2I buildGuidance

• run odo deploy --tag=<imageTag>

NOTE: Please supply complete destination under --tag
( for ex: image-registry.openshift-image-registry.svc:5000/namespace/imagestream or docker.io/username/repository-name)

NOTE: (Relevant to external registry push only) if --dockerconfigjson is not specified, config.json is picked up from ~/.docker. Please ensure the default config.json file contains a valid auth token. External registry push is currently only configured for Dockerhub

NOTE You can pass multiple build guidance in devfile, the first one from list will be picked up to decide build strategy, e.g in below scenario dockerfile guidance will have priority over s2i (Specific to "odo deploy").

buildGuidances:
    - dockerfile:
        name: dockerfile-build
        dockerfileLocation: "https://raw.githubusercontent.com/wtam2018/test/master/nodejs-dockerfiile"
        rootless: true
    - s2i:
        name: s2i-build
        builderImageNamespace: "openshift"
        builderImageStreamTag: "nodejs:12"
        scriptLocation: "https://raw.githubusercontent.com/Shraddhak22/s2i-scripts/master/s2i/bin"
        incrementalBuild: true

[openshift-ci-robot]

@Shraddhak22: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kadel
You can assign the PR to them by writing /assign @kadel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Hi @Shraddhak22. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[girishramnani]

Closing this PR as it has diverged