-
Notifications
You must be signed in to change notification settings - Fork 246
Added completion support for files and directories. #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Climate has analyzed commit b92a37e and detected 0 issues on this pull request. View more on Code Climate. |
|
✅ odo build 176 completed and artifacts can be found here (for commit ec5c4cc317 by @mik-dass) |
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
==========================================
+ Coverage 48.03% 48.16% +0.13%
==========================================
Files 19 19
Lines 2998 2998
==========================================
+ Hits 1440 1444 +4
+ Misses 1405 1401 -4
Partials 153 153
Continue to review full report at Codecov.
|
This completion handler is added to the create command for the local and binary flags. Signed-off-by: mik-dass <mrinald7@gmail.com>
|
✅ odo build 180 completed and artifacts can be found here (for commit 8bf99eabe9 by @mik-dass) |
|
✅ odo build 182 completed and artifacts can be found here (for commit 7609228b97 by @mik-dass) |
metacosm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anmolbabu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
|
@metacosm the PR currently doesn't work for ~ and ../ but it does work for / and other normal situations |
|
@mik-dass supporting |
|
@metacosm Ok 👍 |
|
It is still not working form me :-( (not even with the absolut path) |
|
@kadel Try these steps
Please try and let me know if it works |
|
@kadel Did the above steps work for you? |
|
that helped. Thank you @mik-dass |
|
@kadel Great 👍 |
fixes #960
This completion handler is added to the create command for the local and binary flags.
Signed-off-by: mik-dass mrinald7@gmail.com