Skip to content

Conversation

@mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Nov 9, 2018

fixes #960

This completion handler is added to the create command for the local and binary flags.

Signed-off-by: mik-dass mrinald7@gmail.com

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Nov 9, 2018

Code Climate has analyzed commit b92a37e and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot
Copy link

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #962 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   48.03%   48.16%   +0.13%     
==========================================
  Files          19       19              
  Lines        2998     2998              
==========================================
+ Hits         1440     1444       +4     
+ Misses       1405     1401       -4     
  Partials      153      153
Impacted Files Coverage Δ
pkg/component/watch.go 72.29% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19f9b5...b92a37e. Read the comment docs.

This completion handler is added to the create command for the local and binary flags.
Signed-off-by: mik-dass <mrinald7@gmail.com>
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link
Contributor

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anmolbabu anmolbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@mik-dass
Copy link
Contributor Author

@metacosm the PR currently doesn't work for ~ and ../ but it does work for / and other normal situations

@metacosm
Copy link
Contributor

@mik-dass supporting ~ and ../ could come in a later PR, imo.

@mik-dass
Copy link
Contributor Author

@metacosm Ok 👍

@metacosm metacosm merged commit f79341f into redhat-developer:master Nov 12, 2018
@mik-dass mik-dass deleted the local_comp branch November 12, 2018 10:38
@kadel
Copy link
Member

kadel commented Nov 12, 2018

It is still not working form me :-( (not even with the absolut path)

@mik-dass
Copy link
Contributor Author

@kadel Try these steps

  1. odo --uncomplete
  2. close terminal
  3. restart and do odo --complete
  4. close and restart and try again

Please try and let me know if it works

@mik-dass
Copy link
Contributor Author

@kadel Did the above steps work for you?

@kadel
Copy link
Member

kadel commented Nov 15, 2018

that helped. Thank you @mik-dass

@mik-dass
Copy link
Contributor Author

@kadel Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New suggestion system broke path suggestion in bash/zsh

6 participants