This repository was archived by the owner on Mar 17, 2021. It is now read-only.
Add param for subpath creation to create-all.sh#62
Merged
Conversation
Versions of OpenShift available in minishift do not currently support the kubernetes fix. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configmap value
che-openshift-precreate-subpaths. If false, Che server will not manually create workspace subpaths before mounting them to a workspace pod. Depends on an OpenShift version with fix for kubernetes/kubernetes#41638 and pull request fabric8io/fabric8-online#219.From my testing, it looks like none of the versions of OpenShift available in minishift include the kubernetes fix, so it's better to set the property to true for local development.
Upstream Che PR: eclipse-che/che#5008