Skip to content

chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529)#162

Merged
nickboldt merged 5 commits intomainfrom
apply-values-from-downstream
May 16, 2025
Merged

chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529)#162
nickboldt merged 5 commits intomainfrom
apply-values-from-downstream

Conversation

@nickboldt
Copy link
Copy Markdown
Member

What does this PR do?

chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529)

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…an remove Chart_patch.yaml (RHIDP-7529)

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci openshift-ci Bot requested review from davidfestal and rm3l May 16, 2025 14:24
@nickboldt nickboldt changed the title chore: update default chart settings using... chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529) May 16, 2025
@github-actions
Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt requested review from omajid and removed request for davidfestal May 16, 2025 14:25
@nickboldt nickboldt force-pushed the apply-values-from-downstream branch from 251d2e6 to 10ca12f Compare May 16, 2025 14:26
@github-actions
Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt force-pushed the apply-values-from-downstream branch from febe9e7 to 3ab1905 Compare May 16, 2025 14:27
@omajid
Copy link
Copy Markdown
Member

omajid commented May 16, 2025

I am not familiar enough with this repo or backstage to review this PR :)

Comment thread charts/backstage/Chart.yaml Outdated
Comment thread charts/backstage/Chart.yaml
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

@Omar-AlJaljuli
Copy link
Copy Markdown

LGTM

@nickboldt nickboldt enabled auto-merge (squash) May 16, 2025 15:44
@nickboldt nickboldt merged commit 031297d into main May 16, 2025
7 of 8 checks passed
@nickboldt nickboldt deleted the apply-values-from-downstream branch May 16, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants