Skip to content

chore(ci): Add Snyk scan for Backstage with Orchestrator#165

Merged
rm3l merged 14 commits intoredhat-developer:mainfrom
Fortune-Ndlovu:snyk-scan-backstage-orchestrator
May 22, 2025
Merged

chore(ci): Add Snyk scan for Backstage with Orchestrator#165
rm3l merged 14 commits intoredhat-developer:mainfrom
Fortune-Ndlovu:snyk-scan-backstage-orchestrator

Conversation

@Fortune-Ndlovu
Copy link
Copy Markdown
Member

@Fortune-Ndlovu Fortune-Ndlovu commented May 21, 2025

Description of the change

  • Refactors Snyk scan workflow to use a matrix-driven approach for configuring Helm chart render options.
  • Each scan variant is defined with a name, path, and cliArgs, removing hardcoded conditionals from the job logic.
  • Adds backstage-orchestrator scan using --set flags to enable Orchestrator at scan time only.
  • Ensures all Snyk project names are consistently prefixed with redhat-developer/rhdh-chart/*.

Existing or Associated Issue(s)

https://issues.redhat.com/browse/RHIDP-6631

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

…naming

Signed-off-by: Fortune-Ndlovu <ndlovufortune97@gmail.com>
@openshift-ci openshift-ci Bot requested review from coreydaley and davidfestal May 21, 2025 10:10
@Fortune-Ndlovu Fortune-Ndlovu changed the title Add Snyk scan for Backstage with Orchestrator and consistent project … chore(ci): Add Snyk scan for Backstage with Orchestrator and consistent project … May 21, 2025
@Fortune-Ndlovu Fortune-Ndlovu changed the title chore(ci): Add Snyk scan for Backstage with Orchestrator and consistent project … chore(ci): Add Snyk scan for Backstage with Orchestrator May 21, 2025
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread charts/backstage/values.orchestrator-enabled.yaml Outdated
…te values file

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread charts/backstage/Chart.yaml Outdated
Comment thread .github/workflows/snyk.yaml Outdated
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread .github/workflows/snyk.yaml Outdated
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as discussed alrady, could you temporarily add a pull_request trigger, so that we can see this Workflow in action in this PR? I guess the PR will likely not have access to the repo secrets, but that should be fine. I just want to see how the template rendering steps behave here.

Comment thread .github/workflows/snyk.yaml Outdated
Comment thread .github/workflows/snyk.yaml
Comment thread .github/workflows/snyk.yaml Outdated
…ly on PRs.

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread .github/workflows/snyk.yaml Outdated
…ntry, it just evaluates to an empty string

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread .github/workflows/snyk.yaml
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread .github/workflows/snyk.yaml Outdated
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 22, 2025
@rm3l rm3l merged commit 1b66011 into redhat-developer:main May 22, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants