Skip to content

fix(orchestrator): endless onChange() loop and turning ui:allowNewItems from string to boolean type#1720

Merged
mareklibra merged 1 commit intoredhat-developer:mainfrom
mareklibra:endlessOnChange
Nov 4, 2025
Merged

fix(orchestrator): endless onChange() loop and turning ui:allowNewItems from string to boolean type#1720
mareklibra merged 1 commit intoredhat-developer:mainfrom
mareklibra:endlessOnChange

Conversation

@mareklibra
Copy link
Copy Markdown
Member

@mareklibra mareklibra commented Nov 4, 2025

Multiple small changes at once:


Example of use: rhdhorchestrator/orchestrator-demo#72

…ms from string to boolean type

Signed-off-by: Marek Libra <marek.libra@gmail.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Nov 4, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-orchestrator-form-react workspaces/orchestrator/plugins/orchestrator-form-react patch v2.3.0
@red-hat-developer-hub/backstage-plugin-orchestrator-form-widgets workspaces/orchestrator/plugins/orchestrator-form-widgets patch v1.4.0

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mareklibra
Copy link
Copy Markdown
Member Author

The SonarCloud finding is about using Array.sort() to compare two arrays while ignoring items order.
This is a common technique, so I would ignore that finding unless there is strong opinion against.

Copy link
Copy Markdown
Contributor

@gciavarrini gciavarrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mareklibra mareklibra merged commit 40e4267 into redhat-developer:main Nov 4, 2025
8 of 9 checks passed
mareklibra added a commit that referenced this pull request Nov 5, 2025
…ms from string to boolean type (#1720)

Signed-off-by: Marek Libra <marek.libra@gmail.com>
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
…ms from string to boolean type (redhat-developer#1720)

Signed-off-by: Marek Libra <marek.libra@gmail.com>
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
…ms from string to boolean type (redhat-developer#1720)

Signed-off-by: Marek Libra <marek.libra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants