Add Dark-Mode Support for Cost management#1885
Merged
asmasarw merged 1 commit intoredhat-developer:mainfrom Dec 4, 2025
Merged
Add Dark-Mode Support for Cost management#1885asmasarw merged 1 commit intoredhat-developer:mainfrom
asmasarw merged 1 commit intoredhat-developer:mainfrom
Conversation
asmasarw
requested review from
PreetiW,
batzionb,
mareklibra and
ydayagi
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
asmasarw
force-pushed
the
feature/dark-mode
branch
from
02c5da4 to
3abfe14
Compare
PreetiW
reviewed
Dec 4, 2025
| <div | ||
| style={{ backgroundColor: '#F2F2F2', padding: 16, borderRadius: 8 }} | ||
| style={{ | ||
| backgroundColor: isDarkMode ? '#262626' : '#F2F2F2', |
Contributor
There was a problem hiding this comment.
@asmasarw do you think we can make use of https://mui.com/material-ui/customization/palette/ for such changes?
PreetiW
reviewed
Dec 4, 2025
| const [showInfrastructureCost, setShowInfrastructureCost] = useState(false); | ||
| const [showSupplementaryCost, setShowSupplementaryCost] = useState(false); | ||
| const theme = useTheme(); | ||
| const isDarkMode = (theme.palette as any).mode === 'dark'; |
Contributor
There was a problem hiding this comment.
@asmasarw how about creating a central custom hook which returns the colors required by our plugin rather than checking it every file?
asmasarw
force-pushed
the
feature/dark-mode
branch
from
dfa37ee to
311d7e7
Compare
|
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Both States:
Dark mode and Light mode.
Dark Mode:
Light Mode: