feat(x2a): added /projects/:projectId/modules/:moduleId/log endpoint#2249
Merged
elai-shalev merged 1 commit intoredhat-developer:mainfrom Feb 5, 2026
Merged
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
eloycoto
force-pushed
the
wt-logs-streaming
branch
from
0d70232 to
ccf792b
Compare
- Openapi definition and generated files.
- Router defitinition:
- Rbac
- Check with project/module
- Check if the job has been finished.
- k8s integration if not finished with streaming support.
- Test for the router.
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
wt-logs-streaming
branch
from
ccf792b to
33ce8a4
Compare
|
elai-shalev
reviewed
Feb 5, 2026
Contributor
elai-shalev
left a comment
elai-shalev
left a comment
There was a problem hiding this comment.
looks good, except one comment
| router.get('/projects/:projectId/modules/:moduleId/log', async (req, res) => { | ||
| const endpoint = 'GET /projects/:projectId/modules/:moduleId/log'; | ||
| const { projectId, moduleId } = req.params; | ||
| const streaming = req.query.streaming === true; |
Contributor
There was a problem hiding this comment.
should this be "true" instead? aren't query params string?
the condition may always be false because of it
Contributor
Author
There was a problem hiding this comment.
it's a boolean, no?
- in: query
name: streaming
schema:
type: boolean
required: false
description: Whether to stream logs (text/plain) or return all at once
elai-shalev
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
✔️ Checklist