refactor(scorecard): improve e2e tests with specific card error checks#2254
Merged
jrichter1 merged 2 commits intoredhat-developer:mainfrom Feb 5, 2026
Merged
Conversation
- Add expectCardHasMissingPermission helper to HomePage - Add expectCardHasNoDataFound helper to HomePage - Update tests to verify error states on specific GitHub and Jira cards - Remove redundant expectCardVisible calls
HusneShabbir
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
Changed Packages
|
|
jrichter1
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved e2e test assertions to verify error states on specific scorecard cards (GitHub/Jira) instead of generic article locators.
Changes
expectCardHasMissingPermission()helper toHomePageexpectCardHasNoDataFound()helper toHomePageexpectCardVisiblecallsWhy