chores(x2): refactor X2ADatabaseService tests for better maintainability #2282
Merged
mareklibra merged 3 commits intoredhat-developer:mainfrom Feb 9, 2026
Merged
Conversation
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
mareklibra
changed the title
mareklibra
force-pushed
the
FLPATH-3199.refactor.DBService
branch
from
461be7f to
5390688
Compare
Signed-off-by: Marek Libra <marek.libra@gmail.com>
mareklibra
force-pushed
the
FLPATH-3199.refactor.DBService
branch
from
fa5e19c to
4891c1b
Compare
mareklibra
force-pushed
the
FLPATH-3199.refactor.DBService
branch
from
4891c1b to
8eb1f67
Compare
|
elai-shalev
approved these changes
Feb 9, 2026
Contributor
elai-shalev
left a comment
elai-shalev
left a comment
There was a problem hiding this comment.
lgtm, well done
router refactor will be in a seperate PR?
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: FLPATH-3199
Refactor X2ADatabaseService and its tests into multiple files.
The service and tests grew significantly, making it hard to maintain and understand.
This refactoring reduces the complexity by separating concerns based on projects, modules and jobs while still reusing common functions.
Additional test flows have been added.