feat(adoption-insights): add NFS support to frontend and analytics plugin#2309
Conversation
rohitkrai03
requested review from
a team,
Eswaraiahsapram and
karthikjeeyar
as code owners
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
rohitkrai03
force-pushed
the
nfs-adoption-insights
branch
4 times, most recently
from
e11130e to
bed7389
Compare
|
you will also need to update this path for the tests to run |
HusneShabbir
left a comment
HusneShabbir
left a comment
There was a problem hiding this comment.
Other than the missing ja and it locale support, everything looks good to me.
We should merge rohitkrai03#1
once it has a green CI and QE approval, and only then proceed with merging this PR.
| export default createFrontendPlugin({ | ||
| pluginId: 'analytics-module-adoption-insights', |
There was a problem hiding this comment.
This AnalyticsImplementationBlueprint belongs to app plugin and since this is a frontend-module-plugin we need to use createFrontendModule instead of createFrontendPlugin
| export default createFrontendPlugin({ | |
| pluginId: 'analytics-module-adoption-insights', | |
| export default createFrontendModule({ | |
| pluginId: 'app', |
There was a problem hiding this comment.
Earlier I had the same implementation but when i looked at this Segment plugin migration which was done by the guy who implemented the AnalyticsImplementationBlueprint, I changed it - https://github.com/backstage/community-plugins/pull/5286/changes#diff-86871a93214ea4e28e8fcd2e794fd161b14de984049d711e8a771ded3fdb1cd1R45.
workspaces/adoption-insights/plugins/analytics-module-adoption-insights/src/alpha.ts
Show resolved
Hide resolved
workspaces/adoption-insights/plugins/adoption-insights/src/alpha.tsx
Outdated
Show resolved
Hide resolved
…ugin Signed-off-by: Rohit Rai <rohitkrai03@gmail.com>
rohitkrai03
force-pushed
the
nfs-adoption-insights
branch
2 times, most recently
from
b5d4d8e to
e3e697e
Compare
rohitkrai03
force-pushed
the
nfs-adoption-insights
branch
from
e3e697e to
23c42bb
Compare
Signed-off-by: Rohit Rai <rohitkrai03@gmail.com>
rohitkrai03
force-pushed
the
nfs-adoption-insights
branch
from
23c42bb to
8b1ed88
Compare
…t/ja locales Co-authored-by: Cursor <cursoragent@cursor.com>
|
4 participants
Hey, I just made a Pull Request!
Fixes - https://issues.redhat.com/browse/RHIDP-11627
Fixes - https://issues.redhat.com/browse/RHIDP-11856
Migrates adoption-insights and analytics-module-adoption-insights plugins to Backstage's new frontend system via /alpha entry points. Legacy system remains fully backward compatible.
Screen.Recording.2026-02-11.at.2.19.44.PM.mov
✔️ Checklist