Orchestrator 1.9 backport#2863
Orchestrator 1.9 backport#2863karthikjeeyar merged 3 commits intoredhat-developer:orchestrator-1.9-backportfrom
Conversation
…loper#2834) Empty pruned form data (e.g. display-only ActiveText) made generateReviewTableData return undefined and NestedReviewTable throw. Return {} from generateReviewTableData and guard NestedReviewTable. Add regression test and changeset. Made-with: Cursor
Code Review by Qodo
1. Unhandled rejections in loop
|
|
Review Summary by QodoFix orchestrator form validation errors and UI styling issues
WalkthroughsDescription• Fix multi-step form validation errors dropping or misplacing nested field paths • Preserve async validation errors by running callbacks sequentially instead of concurrently • Handle empty form data in review step to prevent crashes with display-only fields • Fix UI styling issues in workflow results page with Material-UI component imports Diagramflowchart LR
A["Multi-step Forms"] --> B["safeSet Deep Paths"]
A --> C["Sequential Async Validation"]
A --> D["toRootExtraErrors Wrapper"]
B --> E["Fixed Error Structure"]
C --> E
D --> E
F["Review Step"] --> G["generateReviewTableData"]
F --> H["NestedReviewTable Guards"]
G --> I["Empty Form Data Handling"]
H --> I
J["Workflow Results UI"] --> K["Material-UI Imports"]
J --> L["Divider Styling"]
K --> M["Fixed UI Rendering"]
L --> M
File Changes1. workspaces/orchestrator/plugins/orchestrator-form-widgets/src/utils/safeSet.ts
|
rhdh-qodo-merge
Bot
added
documentation
karthikjeeyar
merged commit 4ec3c3f
into
redhat-developer:orchestrator-1.9-backport
* fix(orchestrator): preserve nested extraErrors and async validation errors (#2818) * fix(orchestrator-form): Review step with empty form data (#2834) Empty pruned form data (e.g. display-only ActiveText) made generateReviewTableData return undefined and NestedReviewTable throw. Return {} from generateReviewTableData and guard NestedReviewTable. Add regression test and changeset. Made-with: Cursor * fix(orchestrator-form-react): fix ui styling issues in workflow results page (#2808) --------- Co-authored-by: Lokananda Prabhu <102503482+lokanandaprabhu@users.noreply.github.com>
2 participants
Cherrypick of below PR's
#2834
#2808
#2818