fix(theme): active sidebar nav link styles using aria-current under BackstageSidebar drawer#2887
Merged
lokanandaprabhu merged 1 commit intoredhat-developer:mainfrom Apr 23, 2026
Conversation
…ackstageSidebar drawer
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Changed Packages
|
|
Review Summary by QodoStyle active sidebar nav links with aria-current attribute
WalkthroughsDescription• Add theme styles for active sidebar nav links using aria-current attribute • Apply sidebar interaction background and selected text colors to active links • Support both scoped (#rhdh-sidebar-layout) and unscoped selector variants • Ensure nested MuiTypography labels inherit link color styling Diagramflowchart LR
A["BackstageSidebar drawer styles"] -->|"add aria-current selector"| B["a[aria-current=page] styling"]
B -->|"apply colors"| C["sidebarItemInteractionBackgroundColor"]
B -->|"apply colors"| D["navigationSelectedColor"]
B -->|"inherit styling"| E["MuiTypography labels"]
File Changes1. workspaces/theme/plugins/theme/src/utils/createComponents.ts
|
lokanandaprabhu
pushed a commit
to lokanandaprabhu/rhdh-plugins
that referenced
this pull request
Apr 24, 2026
…ackstageSidebar drawer (redhat-developer#2887)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
https://redhat.atlassian.net/browse/RHDHBUGS-2981
Adds theme overrides on the BackstageSidebar drawer so the current route’s nav link (a[aria-current="page"]) uses the resolved sidebar interaction background and selected text color, with a #rhdh-sidebar-layout scope for higher specificity when that layout wrapper is used. Nested MuiTypography labels inherit the link color.
✔️ Checklist