fix(cost-management): use dots instead of slashes in menuItems keys#3022
Merged
PreetiW merged 2 commits intoredhat-developer:mainfrom May 5, 2026
Merged
Conversation
RHDH expects dots as path separators in menuItems keys (e.g., `cost-management.optimizations`), not slashes. Using slashes causes the menu items to appear as flat top-level entries instead of being nested under the "Cost management" parent menu. See: https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.6/html/installing_and_viewing_plugins_in_red_hat_developer_hub/assembly-front-end-plugin-wiring.adoc_rhdh-extensions-plugins Signed-off-by: pgarciaq <pgarciaq@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
pgarciaq
requested review from
PreetiW,
asmasarw,
batzionb,
mareklibra and
ydayagi
as code owners
Changed Packages
|
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Contributor
Author
|
@PreetiW please take a look. I hit this while installing RHDH on my cluster. |
PreetiW
approved these changes
May 5, 2026
Contributor
|
Thank you for the fix @pgarciaq LGTM 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 2067 2067
Lines 63761 63761
Branches 16532 16535 +3
=======================================
Hits 38735 38735
Misses 24580 24580
Partials 446 446
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menuItemskeys inapp-config.dynamic.yamlto use dots (.) instead of slashes (/) as path separatorsThe RHDH front-end plugin wiring documentation specifies that for a path like
/cost-management/optimizations, the correspondingmenu_item_nameshould becost-management.optimizations(with a dot), notcost-management/optimizations(with a slash).Test plan
app-config.dynamic.yamlMade with Cursor