fix(global-header): localize header search “All results” and clear control#3052
Merged
its-mitesh-kumar merged 1 commit intoMay 6, 2026
Conversation
Wire search autocomplete strings to plugin translations with locale bundles; update SearchOption tests to use shared translation mocks; refresh API reports. Co-authored-by: Cursor <cursoragent@cursor.com>
lokanandaprabhu
requested review from
a team,
ciiay and
divyanshiGupta
as code owners
Changed Packages
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3052 +/- ##
=======================================
Coverage 60.78% 60.78%
=======================================
Files 2067 2067
Lines 63873 63875 +2
Branches 16580 16580
=======================================
+ Hits 38827 38829 +2
Misses 24793 24793
Partials 253 253
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes:
https://redhat.atlassian.net/browse/RHDHBUGS-3074
Improves internationalization for the global-header search autocomplete: the footer link to the full search page and the clear control now use the plugin translation system instead of hardcoded English, with strings added for German, Spanish, French, Italian, and Japanese.
✔️ Checklist