fix(lightspeed): update missing permission illsutration#3261
fix(lightspeed): update missing permission illsutration#3261rohitratannagar wants to merge 3 commits into
Conversation
Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
rohitratannagar
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
==========================================
+ Coverage 53.57% 53.58% +0.01%
==========================================
Files 2407 2408 +1
Lines 86535 86545 +10
Branches 23943 23951 +8
==========================================
+ Hits 46361 46377 +16
+ Misses 38692 38686 -6
Partials 1482 1482
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Playwright < 1.60.0 hangs after browser download on Node 24.16+ during playwright install in GitHub Actions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
/cc @ShiranHi |
HusneShabbir
left a comment
HusneShabbir
left a comment
There was a problem hiding this comment.
/lgtm
Tested locally, works as expected
Screen.Recording.2026-06-02.at.4.20.48.PM.mov
|
@rohitratannagar, the implementation looks a bit different from the Figma design. I’d recommend waiting until @ShiranHi approves the changes. |
|
Thanks for this, @rohitratannagar , it looks great overall. Just two small adjustments:
The rest looks good to go! |
| title={t('permission.required.title')} | ||
| description={ | ||
| <Typography variant="subtitle1"> | ||
| <div className={classes.root}> |
There was a problem hiding this comment.
@rohitratannagar Could you please try to re-use , and if you are facing any issue related to image to fit in in overlay mode, take help of Shiran.
Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
|
New changes are detected. LGTM label has been removed. |
|
4 participants
Summary
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3152
PermissionRequiredStateto reuse Backstage's<EmptyState/>component from@backstage/core-components, aligning with the pattern used inadoption-insightsclamp()andcqiunitsUI after changes
Screen.Recording.2026-06-02.at.1.02.02.AM.mov
✔️ Checklist