Skip to content

feat(translations): migrate app package from Material UI v4 to MUI v5#3607

Merged
its-mitesh-kumar merged 3 commits into
redhat-developer:mainfrom
its-mitesh-kumar:feat/translations-mui5-migration
Jun 29, 2026
Merged

feat(translations): migrate app package from Material UI v4 to MUI v5#3607
its-mitesh-kumar merged 3 commits into
redhat-developer:mainfrom
its-mitesh-kumar:feat/translations-mui5-migration

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Jun 28, 2026

Copy link
Copy Markdown
Member

Description

Migrate the translations workspace app package from @material-ui/core (MUI v4) to @mui/material (MUI v5). This removes the legacy Material UI v4 dependencies from the dev app shell, replacing them with MUI v5 equivalents. Local LogoFull/LogoIcon components are replaced with shared exports from @red-hat-developer-hub/backstage-plugin-theme. An ESLint restriction guard is added to prevent re-introduction of MUI v4 imports.

The translations plugin itself was already on MUI v5 — only the app shell needed migration.

Fixed

UI after changes

S_.2026-06-28.at.6.51.18.PM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info) — N/A: only private packages/app changed (not published)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes — existing tests pass
  • Screenshots attached (for UI changes)

Replace @material-ui/core and @material-ui/icons with @mui/material and
@mui/icons-material in the translations workspace app shell. Delete local
LogoFull/LogoIcon components in favor of the shared theme plugin exports.
Add ESLint guard to prevent MUI v4 re-introduction.

Signed-off-by: Mitul Kumar <mitulkumar2000@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 28, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/translations/packages/app none v0.0.0

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.21%. Comparing base (e01563c) to head (2cf884e).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3607   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files        2312     2312           
  Lines       88533    88533           
  Branches    24714    24714           
=======================================
  Hits        48001    48001           
+ Misses      40185    40182    -3     
- Partials      347      350    +3     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from 1c89e1d
ai-integrations 67.95% <ø> (ø) Carriedforward from 1c89e1d
app-defaults 69.79% <ø> (ø) Carriedforward from 1c89e1d
augment 46.39% <ø> (ø) Carriedforward from 1c89e1d
boost 74.35% <ø> (ø) Carriedforward from 1c89e1d
bulk-import 72.46% <ø> (ø) Carriedforward from 1c89e1d
cost-management 14.10% <ø> (ø) Carriedforward from 1c89e1d
dcm 61.81% <ø> (ø) Carriedforward from 1c89e1d
extensions 61.53% <ø> (ø) Carriedforward from 1c89e1d
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 1c89e1d
global-header 59.71% <ø> (ø) Carriedforward from 1c89e1d
homepage 49.84% <ø> (ø) Carriedforward from 1c89e1d
install-dynamic-plugins 56.77% <ø> (ø) Carriedforward from 1c89e1d
konflux 91.49% <ø> (ø) Carriedforward from 1c89e1d
lightspeed 68.54% <ø> (ø) Carriedforward from 1c89e1d
mcp-integrations 85.46% <ø> (ø) Carriedforward from 1c89e1d
orchestrator 38.30% <ø> (ø) Carriedforward from 1c89e1d
quickstart 63.76% <ø> (ø) Carriedforward from 1c89e1d
sandbox 79.56% <ø> (ø) Carriedforward from 1c89e1d
scorecard 82.67% <ø> (ø) Carriedforward from 1c89e1d
theme 61.26% <ø> (ø) Carriedforward from 1c89e1d
translations 7.25% <ø> (ø)
x2a 78.68% <ø> (ø) Carriedforward from 1c89e1d

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01563c...2cf884e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:32 AM UTC · Completed 10:45 AM UTC
Commit: 2fd75ad · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [missing-authorization] — The PR has no linked GitHub issue. The body references Jira RHIDP-13846, which cannot be verified from within this repository. Non-trivial changes (dependency migration, ESLint config additions, component deletions) benefit from explicit, verifiable authorization via a linked GitHub issue.

  • [ESLint config consistency] workspaces/translations/eslint.frontend-shared.cjs:24 — The restrictedImports array includes an explicit entry for @material-ui/icons, but restrictedImportPatterns: ['@material-ui/*'] already catches all @material-ui/* imports. The explicit entry is redundant but provides a more specific error message. Among the nine existing eslint.frontend-shared.cjs files in the repo, the homepage workspace also includes this entry, so this is not unique to this PR.

Comment thread workspaces/translations/eslint.frontend-shared.cjs
@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 29, 2026

@ciiay ciiay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified in dev app and it works as expected.

pr_3607.mp4

@openshift-ci openshift-ci Bot added the lgtm label Jun 29, 2026
@its-mitesh-kumar its-mitesh-kumar merged commit a8026af into redhat-developer:main Jun 29, 2026
33 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm ready-for-merge All reviewers approved — ready to merge workspace/translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants