Skip to content

fix(orchestrator): improved devMode, revert last yaml change#408

Merged
gciavarrini merged 1 commit intoredhat-developer:mainfrom
gautamkrishnar:fix/devmode1
Feb 14, 2025
Merged

fix(orchestrator): improved devMode, revert last yaml change#408
gciavarrini merged 1 commit intoredhat-developer:mainfrom
gautamkrishnar:fix/devmode1

Conversation

@gautamkrishnar
Copy link
Copy Markdown
Contributor

@gautamkrishnar gautamkrishnar commented Feb 12, 2025

  • Added check for resourcesPath before cloning
  • Added code to remove the git history of the cloned workflow repo to prevent any future issues with git submodules
  • Reverted app-config.yaml change made by 4b008c4

Created based on discussion here: https://redhat.enterprise.slack.com/archives/C059YMMB664/p1739370779251939

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Feb 12, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-orchestrator-backend workspaces/orchestrator/plugins/orchestrator-backend patch v5.2.0

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@jkilzi jkilzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gciavarrini gciavarrini merged commit bad7cb0 into redhat-developer:main Feb 14, 2025
@gautamkrishnar gautamkrishnar deleted the fix/devmode1 branch February 14, 2025 10:01
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants