fix(orchestrator):Add status icons#613
Conversation
LiorSoffer
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
Changed Packages
|
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
Can you please check WorkflowProgressNode.tsx as well and fix it in case of significant inconsistencies?
There was a problem hiding this comment.
| icon = <CircularProgress size="1.15rem" />; | |
| icon = <CircularProgress size="1.15rem" className={iconColor} />; |
Maybe there is no obvious change but it will make the code coherent.
There was a problem hiding this comment.
it bothers me as well thanks :)
|
@ShiranHi what do you think? |
|
Thank you Lior, looks great!
|
|
@ShiranHi yes! , regarding the pending icon I couldn't find the exact one on https://v4.mui.com/components/material-icons/, is there something else there which is more suitable? |
Can we use this one? |
|
@ShiranHi please take a look |
|
Looks great Lior, thank you so much! |
|
@ShiranHi @mareklibra np, icon is fixed |
|
@ShiranHi , can we choose something from https://mui.com/material-ui/material-icons/ ? @LiorSoffer By choosing a MUI icon, following will not be relevant. But to give some hints: we should use an svg icon file committed to our project and use it instead of the recent approach. |
Yes, we can use the HourglassEmpty icon |
Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>
| title = 'Completed'; | ||
| break; | ||
| case ProcessInstanceStatusDTO.Suspended: | ||
| icon = <b className={iconColor}>--</b>; |
There was a problem hiding this comment.
The last one, I promise: We use 3 dashes on other places (---). I don't have any preference what to choose but we should align.
There was a problem hiding this comment.
We use 3 dashes for unavailable value , I think suspended is a different scenario than unavailable
@ShiranHi @mareklibra what do you think?
There was a problem hiding this comment.
Let's use the WarningAmberOutlined icon for Unavailable status as in the design.
There was a problem hiding this comment.
sorry, I was unclear. there's not an Unavailable status,
There are cases in the app when we are missing values for example (last run of workflow which was never executed, image added) in these cases we use 3 dashes.
There was a problem hiding this comment.
ah, got it. Thanks for the clarification!
We use just two dashes (--) to indicate this state.
|
Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>
3 participants
resolve FLPATH-2253