Skip to content

fix(theme): integrate with RHDH#623

Merged
ciiay merged 2 commits intoredhat-developer:mainfrom
ciiay:rhidp-6601-release-theme-package
Apr 7, 2025
Merged

fix(theme): integrate with RHDH#623
ciiay merged 2 commits intoredhat-developer:mainfrom
ciiay:rhidp-6601-release-theme-package

Conversation

@ciiay
Copy link
Copy Markdown
Member

@ciiay ciiay commented Apr 7, 2025

Hey, I just made a Pull Request!

This PR is for RHIDP-6601 and RHIDP-6603, with a fixed changeset

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

ciiay added 2 commits April 7, 2025 18:57
* fix(theme): integrate with RHDH

Signed-off-by: Yi Cai <yicai@redhat.com>

* some minor ref changes

Signed-off-by: Yi Cai <yicai@redhat.com>

* minor fix

Signed-off-by: Yi Cai <yicai@redhat.com>

* fix outlined button style issue

Signed-off-by: Yi Cai <yicai@redhat.com>

* added changeset

Signed-off-by: Yi Cai <yicai@redhat.com>

* changed changeset

Signed-off-by: Yi Cai <yicai@redhat.com>

* updated package.json and yarn.lock

Signed-off-by: Yi Cai <yicai@redhat.com>

* yarn dedupe

Signed-off-by: Yi Cai <yicai@redhat.com>

* yarn build:api-reports

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Apr 7, 2025

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • /home/runner/work/rhdh-plugins/rhdh-plugins/workspaces/theme/.changeset/version-bump-1-36-1.md: @red-hat-developer-hub/backstage-plugin-bc-test, @red-hat-developer-hub/backstage-plugin-mui4-test, @red-hat-developer-hub/backstage-plugin-mui5-test

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-theme workspaces/theme/plugins/theme minor v0.5.0

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
24.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ciiay ciiay merged commit cbb46e4 into redhat-developer:main Apr 7, 2025
9 of 10 checks passed
ciiay added a commit to ciiay/rhdh-plugins that referenced this pull request Apr 14, 2025
ciiay added a commit that referenced this pull request Apr 14, 2025
* Revert "Version Packages (#624)"

This reverts commit 70390bb.

* Revert "fix(theme): integrate with RHDH (#623)"

This reverts commit cbb46e4.
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
* fix(theme): integrate with RHDH (redhat-developer#572)

* fix(theme): integrate with RHDH

Signed-off-by: Yi Cai <yicai@redhat.com>

* some minor ref changes

Signed-off-by: Yi Cai <yicai@redhat.com>

* minor fix

Signed-off-by: Yi Cai <yicai@redhat.com>

* fix outlined button style issue

Signed-off-by: Yi Cai <yicai@redhat.com>

* added changeset

Signed-off-by: Yi Cai <yicai@redhat.com>

* changed changeset

Signed-off-by: Yi Cai <yicai@redhat.com>

* updated package.json and yarn.lock

Signed-off-by: Yi Cai <yicai@redhat.com>

* yarn dedupe

Signed-off-by: Yi Cai <yicai@redhat.com>

* yarn build:api-reports

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>

* fix a mixed changeset

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
* Revert "Version Packages (redhat-developer#624)"

This reverts commit fa5cc05.

* Revert "fix(theme): integrate with RHDH (redhat-developer#623)"

This reverts commit acda022.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants