fix(sandbox): some css updates#752
Conversation
mfrancisc
requested review from
Lucifergene,
alexeykazakov,
karthikjeeyar and
rohitkrai03
as code owners
Changed Packages
|
|
Lucifergene
left a comment
Lucifergene
left a comment
There was a problem hiding this comment.
@mfrancisc I have reviewed this PR. Have put some comments.
You can update accordingly in ur new PR #765
There was a problem hiding this comment.
Please revert this complete file. It will fix the regression
There was a problem hiding this comment.
There was a problem hiding this comment.
Please revert this complete file. It will fix the regression
There was a problem hiding this comment.
why ? This fixes the problem with the cards breaking into two lines. See point 1 here:https://redhat-internal.slack.com/archives/C085PFGDLGY/p1746604014832279?thread_ts=1746541820.107489&cid=C085PFGDLGY
There was a problem hiding this comment.
The regression is already fixed with the change in #765 ( unit test is WIP so it catches regressions ).
There was a problem hiding this comment.
Also changes in this file are not related to the issue with the header 😕
| throw new Error( | ||
| 'Invalid phone number. Please verify the country code and number format, then try again.', | ||
| ); |
There was a problem hiding this comment.
if !response.ok, there can be other errors too apart from Invalid phone Number.
Therefore it would be good to add a condition to check that error?.message starts with Invalid phone number. Only then show the error message. Otherwise just throw error?.message.
There was a problem hiding this comment.
makes sense. Let me improve it.
There was a problem hiding this comment.
| <Link to="#" underline="none"> | ||
| AAP documentation. | ||
| New to Ansible Automation Platform? Get up to speed with our{' '} | ||
| <Link to="http://red.ht/ansibledevsandboxpath" underline="none"> |
* css updates --------- Co-authored-by: Devtools <devtools@redhat.com>
3 participants
WRT: https://issues.redhat.com/browse/RHDHPAI-792