Question validation disable option#767
Merged
yangcao77 merged 12 commits intoMay 13, 2025
Merged
Conversation
Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
…question-validation-disable-option
…question-validation-disable-option
Signed-off-by: Stephanie <yangcao@redhat.com>
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
4 tasks
…question-validation-disable-option
|
karthikjeeyar
approved these changes
May 13, 2025
Member
karthikjeeyar
left a comment
karthikjeeyar
left a comment
There was a problem hiding this comment.
Verified locally, works fine
/lgtm
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
* add RHDH system prompt Signed-off-by: Stephanie <yangcao@redhat.com> * add optional boolean value to config Signed-off-by: Stephanie <yangcao@redhat.com> * remove system prompt from lightspeed plugin Signed-off-by: Stephanie <yangcao@redhat.com> --------- Signed-off-by: Stephanie <yangcao@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
for issue https://issues.redhat.com/browse/RHDHPAI-759
add optional boolean plugin configuration
disableQuestionValidationalso due to the change in road-core, road-core/service#567
we are now providing all RHDH customized prompt in road-core
thus, remove the rhdh prompt from lightspeed plugin.
to test locally, the simplest way is change the value from
olstorhdhbefore start rcs locally: https://github.com/road-core/service/blob/b06b739bf6eefd42fe6838ef9c5e758e34323b62/ols/customize/__init__.py#L6or if use rhdh image, provide
PROJECT=rhdhENV when start the containere.g.
✔️ Checklist