Skip to content

fix(theme): support global-header above-sidebar position#834

Merged
ciiay merged 1 commit intoredhat-developer:mainfrom
logonoff:fix-above-sidebar
May 27, 2025
Merged

fix(theme): support global-header above-sidebar position#834
ciiay merged 1 commit intoredhat-developer:mainfrom
logonoff:fix-above-sidebar

Conversation

@logonoff
Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

after:

image

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented May 22, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-theme workspaces/theme/plugins/theme patch v0.8.1

@sonarqubecloud
Copy link
Copy Markdown

@ciiay
Copy link
Copy Markdown
Member

ciiay commented May 23, 2025

Thanks for the fix @logonoff 👍
Have you tested this pr in RHDH with multiple headers such as

  • 2 headers above sidebar
  • 2 headers above main content
  • 1 header above sidebar + 1 header above main content

I also noticed that the top right border radius looks smaller than others in your screenshot, and the scrollbar is outside of the main content.

@logonoff
Copy link
Copy Markdown
Member Author

Thanks for the fix @logonoff 👍 Have you tested this pr in RHDH with multiple headers such as

* 2 headers above sidebar

* 2 headers above main content

* 1 header above sidebar + 1 header above main content

I also noticed that the top right border radius looks smaller than others in your screenshot, and the scrollbar is outside of the main content.

two headers above sidebar + two headers above main content

image

one above sidebar + one above main content

image

two above sidebar

image

two above main content

image

Copy link
Copy Markdown
Member

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for the PR 🚀

@openshift-ci openshift-ci Bot added the lgtm label May 27, 2025
@ciiay ciiay merged commit 275d8b1 into redhat-developer:main May 27, 2025
9 checks passed
@logonoff logonoff deleted the fix-above-sidebar branch May 27, 2025 13:11
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants