Skip to content

ci: add knip reports check to CI#930

Merged
04kash merged 2 commits into
redhat-developer:mainfrom
04kash:knip
Jun 17, 2025
Merged

ci: add knip reports check to CI#930
04kash merged 2 commits into
redhat-developer:mainfrom
04kash:knip

Conversation

@04kash
Copy link
Copy Markdown
Member

@04kash 04kash commented Jun 9, 2025

Hey, I just made a Pull Request!

Add Opt-in knip reports check to CI in the rhdh-plugins repo based on what was added in the community-plugins repo (backstage/community-plugins#4046)

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Jun 9, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/rhdh-repo-tools workspaces/repo-tools/packages/cli none v0.0.1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 9, 2025

Copy link
Copy Markdown
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit, but I'm not an expert on process re: updating everyone's package.json to add a new method call.

Copy link
Copy Markdown
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the same functionality upstream. package.json that are updated are at the workspace-level, rather than the plugin, so this would not impact shipped assets.

@04kash 04kash merged commit f1c6aeb into redhat-developer:main Jun 17, 2025
33 checks passed
@04kash 04kash deleted the knip branch June 17, 2025 15:33
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants