fix(lightspeed): Make Source card links as external links#947
Merged
rohitkrai03 merged 3 commits intoJun 16, 2025
Conversation
Changed Packages
|
karthikjeeyar
force-pushed
the
source-card-links
branch
from
4a29a5e to
0e16b83
Compare
|
maysunfaisal
approved these changes
Jun 12, 2025
Contributor
maysunfaisal
left a comment
maysunfaisal
left a comment
There was a problem hiding this comment.
lgtm
Since road-core/service#634 has merged, can you build a latest image with the change? I can try it out on a cluster after you push the changes to latest.
Contributor
|
/approve |
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
…eloper#947) * make source card links external * add changeset * add more unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes:
https://issues.redhat.com/browse/RHDHPAI-879
This PR reads the source card links from
addtional_kwargs.referenced_documentsand make it as external links.Screenshots:
✔️ Checklist