fix(orchestrator): fix CSS bugs for variables dialog and input schema…#990
fix(orchestrator): fix CSS bugs for variables dialog and input schema…#990batzionb merged 1 commit intoredhat-developer:mainfrom
Conversation
LiorSoffer
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
Changed Packages
|
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
Thanks, this is a great improvement.
| return ( | ||
| <Paper | ||
| elevation={1} | ||
| sx={{ |
There was a problem hiding this comment.
Can these sx properties be replaced by classes? (makeStyles etc.)
Let's not mix different code styles unless necessary.
| paddingBottom: theme.spacing(2), | ||
| backgroundColor: isDarkMode ? '#151515' : '#F0F0F0', | ||
| maxWidth: 600, | ||
| marginTop: '10px', |
There was a problem hiding this comment.
we should use rem and not px
There was a problem hiding this comment.
reason being - when you make the font bigger the size doesn't adjust when it's px
|
@LiorSoffer |
|
@batzionb it looked bad plus the syntax highlighting was red and I couldn't change it |
| padding: '25px 0', | ||
| }} | ||
| /> | ||
| <JsonCodeBlock isDarkMode={isDarkMode} value={inputSchema} /> |
There was a problem hiding this comment.
| <JsonCodeBlock isDarkMode={isDarkMode} value={inputSchema} /> | |
| <JsonCodeBlock isDarkMode={isDarkMode} value={inputSchema?.inputSchema} /> |
There was a problem hiding this comment.
this way we will see the input schema directly instead of being wrapped by another layer with key inputSchema
… dialog Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>
|
… dialog (redhat-developer#990) Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>
3 participants
resolve FLPATH-2417