Skip to content

Conversation

@nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Nov 7, 2024

Description

Enforcing naming conventions on files and code elements

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Contributor

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 22, 2024

/retest

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@zdrapela
Copy link
Member

/lgtm

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@josephca
Copy link
Member

/lgtm
/approve

It's almost impossible to review all files :) but the refactoring for the naming convention was LGTM

@openshift-ci
Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca, zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7a80e46 into redhat-developer:main Nov 27, 2024
12 checks passed
chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Aug 3, 2025
* style more like

* add anotation about running on CI

* expanding and grouping developer guidelines

* add paths ignore for e2e docs

* adding Use of External Sources for Validation

* reorganization

* delete innecessari duplications of principles for new PRs

* move e2e contributing file

* delete duplicates

* +readme.md

* improve e2e lint

* enforce naming

* enforce case with lint

* fix broken waitForNextSync

* add prettier and lint check for e2e

* fix missing lint errors

* fix problem caused on github-helper

* rename catalog

* wip

* delete logger

* + logger

* update for catalog path

* rename logs again

* fix lint check on CI

* + POM

* wip on RbacPo

* wip

* wip

wip

wip

replace old references with rbacPo

* amenda

* adjust kubeclient naming and usage

* wip

* fix merge conflicts

* rename typo on KubeClient

* wip

* wip

* fix lint

* fix tests

* minor fixes

* fix main conflicts

* ignore any for lint

---------

Co-authored-by: Joseph Kim <joskim@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants