Skip to content

Conversation

@gustavolira
Copy link
Member

feat: add [skip-build] tag support to skip unnecessary builds

Description

This PR introduces a new feature to skip the image build step using a commit message tag.

Changes:

  • Added support for [skip-build] tag in commit messages to skip the image build step
  • Added is_skipped output to the check-image-and-changes action
  • Updated build skip logic to prevent unnecessary builds and comments
  • Build will be skipped if the commit message contains [skip-build] anywhere in the message

Example usage:
git commit -m "feat: update e2e tests [skip-build]"

This change provides more flexibility by:

  • Allowing build skipping on any branch when needed
  • Making the skip intention explicit in git history
  • Enabling easy toggling of build skipping without branch changes
  • Preventing unnecessary comments on PRs when build is skipped

Note: The e2e tests will still run even when the build is skipped.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

  1. Create a new PR with changes
  2. Add [skip-build] to the commit message
  3. Verify that:
    • The image build step is skipped
    • No comment is added to the PR about image availability
    • E2E tests still run normally

@github-actions
Copy link
Contributor

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

…uilds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
…uilds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
…uilds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
…uilds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
@github-actions
Copy link
Contributor

…uilds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
@github-actions
Copy link
Contributor

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot removed the lgtm label May 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt added the lgtm label May 29, 2025
@nickboldt nickboldt enabled auto-merge (squash) May 29, 2025 05:21
@github-actions
Copy link
Contributor

@nickboldt nickboldt merged commit 9186481 into redhat-developer:main May 29, 2025
12 of 13 checks passed
chadcrum pushed a commit to chadcrum/rhdh that referenced this pull request Aug 3, 2025
…uilds (redhat-developer#2922)

* feat(build): add support for [skip-build] tag to conditionally skip builds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

* feat(build): add support for [skip-build] tag to conditionally skip builds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

* feat(build): add support for [skip-build] tag to conditionally skip builds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

* feat(build): add support for [skip-build] tag to conditionally skip builds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

* feat(build): add support for [skip-build] tag to conditionally skip builds

Signed-off-by: Gustavo Lira <guga.java@gmail.com>

---------

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants