chore: remove community plugin wrappers #3960
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
josephca
changed the title
|
The image is available at: /test e2e-ocp-helm |
nickboldt
changed the title
|
The image is available at: /test e2e-ocp-helm |
|
continued in #3963 (4 more wrappers to remove) |
|
The image is available at: /test e2e-ocp-helm |
|
The image is available at: /test e2e-ocp-helm |
josephca
force-pushed
the
removeCommunityPlgWrapper
branch
from
c06717f to
3eba605
Compare
|
Why do you skip the build and esp e2e tests here? |
|
Why do we need to run tests to confirm removal of wrappers is safe? these are all community plugins so we shouldn't be doing e2e tests on them... right? |
|
The image is available at: /test e2e-ocp-helm |
|
@josephca: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Would it be worth waiting until we get further with RHIDP-9420 as from a little peeking around, these changes render some lines from our default plugin configuration (like this quay scaffolder thingie or this 3scale backend thingy ) invalid. If we don't intend to ship them by default we should remove the corresponding items from the Anyways, I spun up an instance of the PR container locally since it seemed odd the tests failed (aren't they skipped anyways?), seemed to run okay for me. |
It seems to be a glitch. I've noticed it as well. |
nickboldt
changed the title
not a glitch; I put it on there to save time |
this will be regenerated once we have a new index container build that excludes these wrappers |
6 participants
Description
remove community plugin wrappers from 1.9
Which issue(s) does this PR fix