-
Notifications
You must be signed in to change notification settings - Fork 211
chore: rename marketplace package name to extensions #4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: rename marketplace package name to extensions #4006
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR TypeEnhancement Description
|
| Relevant files | |||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Enhancement | |||||||||||||||||||||||||
| Tests | 1 files
| ||||||||||||||||||||||||
| Configuration changes | 12 files
| ||||||||||||||||||||||||
| Documentation | 5 files
| ||||||||||||||||||||||||
| Additional files |
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
nickboldt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: /test e2e-ocp-helm |
|
only 1 of 44 tests failed with can we ignore that? seems unrelated... |
|
New changes are detected. LGTM label has been removed. |
|
The image is available at: /test e2e-ocp-helm |
|
/retest |
bd161ef to
37e7b3f
Compare
|
The image is available at: /test e2e-ocp-helm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(refer the following comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @karthikjeeyar 🤝
It looks to me only one thing I noticed. In e2e-tests/playwright/e2e/extensions.spec.ts, it still uses plugin.marketplace to locate the headings. Will this be a problem? The rest is all good 👍
|
@ciiay I have updated that reference in extensions.spec.ts. I also noticed that e2e job is broken in all the PRs and the errors seems to be unrelated to PR changes. |
c39c370 to
f9d0978
Compare
|
|
The image is available at: /test e2e-ocp-helm |
|
/retest |
|
@karthikjeeyar: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |




Description
Rename marketplace wrapper package names to
extensions-*Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-11431
Imported example catalog entities from rhdh-plugins repository: https://github.com/redhat-developer/rhdh-plugins/tree/main/workspaces/extensions/examples
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer